perf(proxy-agent): avoid extra header allocations in auth guard#5164
Merged
mcollina merged 2 commits intonodejs:mainfrom May 6, 2026
Merged
perf(proxy-agent): avoid extra header allocations in auth guard#5164mcollina merged 2 commits intonodejs:mainfrom
mcollina merged 2 commits intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5164 +/- ##
==========================================
- Coverage 93.26% 93.26% -0.01%
==========================================
Files 110 110
Lines 36353 36370 +17
==========================================
+ Hits 33906 33919 +13
- Misses 2447 2451 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
ProxyAgent request header handling performance.
Rationale
ProxyAgent does extra work on in it's
Proxy-Authorizationguard every dispatch. Object headers currently allocate anObject.keys()array before scanning, and array headers are converted before the guard runs.Changes
Proxy-Authorizationwhile converting them inbuildHeaders().Object.keys().find()with afor...inearly-exit scan for object headers.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5